Re: [PATCH net v2] net: phy: spi_ks8995: Do not overwrite SPI mode flags

From: Sven Van Asbroeck
Date: Tue Nov 10 2020 - 11:51:02 EST


Hi Andy, thank you for the feedback.

On Tue, Nov 10, 2020 at 11:30 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> I see that this is a fix for backporing, but maybe you can send a
> patches on top of this to:
> 1) introduce
> #define SPI_MODE_MASK (SPI_CPHA | SPI_CPOL)
> spi->mode &= ~SPI_MODE_MASK;
>

Andrew Lunn suggested that a spi helper function would
probably fit the bill. I am planning to submit that to net-next
after this patch is accepted in next (and next is merged into
net-next).

I am learning that net is only for the most minimal of fixes.

See the previous discussion here:
https://patchwork.ozlabs.org/project/netdev/patch/20201109193117.2017-1-TheSven73@xxxxxxxxx/