Re: [PATCH v2 net-next] net: udp: introduce UDP_MIB_MEMERRORS for udp_mem

From: Jakub Kicinski
Date: Mon Nov 09 2020 - 19:40:35 EST


On Thu, 5 Nov 2020 20:49:14 -0500 menglong8.dong@xxxxxxxxx wrote:
> From: Menglong Dong <dong.menglong@xxxxxxxxxx>
>
> When udp_memory_allocated is at the limit, __udp_enqueue_schedule_skb
> will return a -ENOBUFS, and skb will be dropped in __udp_queue_rcv_skb
> without any counters being done. It's hard to find out what happened
> once this happen.
>
> So we introduce a UDP_MIB_MEMERRORS to do this job. Well, this change
> looks friendly to the existing users, such as netstat:
>
> $ netstat -u -s
> Udp:
> 0 packets received
> 639 packets to unknown port received.
> 158689 packet receive errors
> 180022 packets sent
> RcvbufErrors: 20930
> MemErrors: 137759
> UdpLite:
> IpExt:
> InOctets: 257426235
> OutOctets: 257460598
> InNoECTPkts: 181177
>
> v2:
> - Fix some alignment problems
>
> Signed-off-by: Menglong Dong <dong.menglong@xxxxxxxxxx>

Applied, thanks!