Re: [PATCH net-next v1] net: phy: spi_ks8995: Do not overwrite SPI mode flags

From: Andrew Lunn
Date: Mon Nov 09 2020 - 14:49:44 EST


> +++ b/drivers/net/phy/spi_ks8995.c
> @@ -491,7 +491,9 @@ static int ks8995_probe(struct spi_device *spi)
>
> spi_set_drvdata(spi, ks);
>
> - spi->mode = SPI_MODE_0;
> + /* use SPI_MODE_0 without changing any other mode flags */
> + spi->mode &= ~(SPI_CPHA | SPI_CPOL);
> + spi->mode |= SPI_MODE_0;
> spi->bits_per_word = 8;

Did you check to see if there is a help to set just the mode without
changing any of the other bits?

Andrew