Re: [PATCH] net: udp: remove redundant initialization in udp_gro_complete

[Jakub Kicinski]

On Fri,  6 Nov 2020 01:42:39 -0500 menglong8.dong@xxxxxxxxx wrote:
>  {
>  	__be16 newlen = htons(skb->len - nhoff);
>  	struct udphdr *uh = (struct udphdr *)(skb->data + nhoff);
> -	int err = -ENOSYS;
> +	int err;
>  	struct sock *sk;

You can also move the err declaration below struct sock *sk; to get
this closer to revert xmas tree order. In other patches it'd increase
change / potential conflict radius but here the correct position is
close enough so we can move.