Re: [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it

From: Lee Jones
Date: Mon Nov 09 2020 - 04:17:12 EST


On Sun, 08 Nov 2020, Dmitry Torokhov wrote:

> On Wed, Nov 04, 2020 at 04:24:22PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > In file included from drivers/input/touchscreen/cyttsp_i2c_common.c:24:
> > drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> > 236 | static const char const cyttsp4_tch_abs_string[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > In file included from drivers/input/touchscreen/cyttsp4_i2c.c:17:
> > drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> > 236 | static const char * const cyttsp4_tch_abs_string[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > In file included from drivers/input/touchscreen/cyttsp4_spi.c:17:
> > drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=]
> > 236 | static const char * const cyttsp4_tch_abs_string[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~~
> >
> > Cc: Ferruh Yigit <fery@xxxxxxxxxxx>
> > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> > Cc: "at www.cypress.com" <ttdrivers@xxxxxxxxxxx>
> > Cc: linux-input@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> Applied, thank you.

Thanks for this Dmitry.

I'll rebase in a couple of days and fix the stragglers.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog