Re: About regression caused by commit aea6cb99703e ("regulator: resolve supply after creating regulator")

From: Michał Mirosław
Date: Sun Nov 08 2020 - 12:22:47 EST


On Sun, Nov 08, 2020 at 03:35:33PM +0800, Qu Wenruo wrote:
> Hi Michał,
>
> Recently when testing v5.10-rc2, I found my RK3399 boards failed to boot
> from NVME.
>
> It turns out that, commit aea6cb99703e ("regulator: resolve supply after
> creating regulator") seems to be the cause.
>
> In RK3399 board, vpcie1v8 and vpcie0v9 of the pcie controller is
> provided by RK808 regulator.
> With that commit, now RK808 regulator fails to register:
>
> [ 1.402500] rk808-regulator rk808-regulator: there is no dvs0 gpio
> [ 1.403104] rk808-regulator rk808-regulator: there is no dvs1 gpio
> [ 1.419856] rk808 0-001b: failed to register 12 regulator
> [ 1.422801] rk808-regulator: probe of rk808-regulator failed with
> error -22

Hi,

This looks lika the problem fixed by commit cf1ad559a20d ("regulator: defer
probe when trying to get voltage from unresolved supply") recently accepted
to regulator tree [1]. Can you verify this?

[1] git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Best Regards
Michał Mirosław