Re: [PATCH 4.14 v2 ] platform/x86: Corrects warning: missing braces around initializer

From: Andy Shevchenko
Date: Fri Oct 30 2020 - 12:51:29 EST


On Fri, Oct 30, 2020 at 08:55:01AM -0700, john.p.donnelly@xxxxxxxxxx wrote:
> From: John Donnelly <john.p.donnelly@xxxxxxxxxx>
>
> The assignment statement of a local variable "struct tp_nvram_state s[2] = {0};
> is not valid for all versions of compilers.

I don't get the subject. IS it backport of existing change to v4.14, or you are
trying to fix v4.14? If the latter is the case, it's not correct order. Try
latest vanilla first (v5.10-rc1 as of today) and if there is still an issue,
submit a patch.

> Fixes: 515ded02bc4b ("platform/x86: thinkpad_acpi: initialize tp_nvram_state variable")
>
> Signed-off-by: John Donnelly <john.p.donnelly@xxxxxxxxxx>

Should not be blank line in between.

--
With Best Regards,
Andy Shevchenko