Re: [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

From: Willem de Bruijn
Date: Fri Oct 30 2020 - 12:30:08 EST


On Thu, Oct 29, 2020 at 10:33 PM Xie He <xie.he.0141@xxxxxxxxx> wrote:
>
> When an skb is received on a normal (non-Ethernet-emulating) PVC device,
> call skb_reset_mac_header before we pass it to upper layers.
>
> This is because normal PVC devices don't have header_ops, so any header we
> have would not be visible to upper layer code when sending, so the header
> shouldn't be visible to upper layer code when receiving, either.
>
> Cc: Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>
> Cc: Krzysztof Halasa <khc@xxxxxxxxx>
> Signed-off-by: Xie He <xie.he.0141@xxxxxxxxx>

Acked-by: Willem de Bruijn <willemb@xxxxxxxxxx>

Should this go to net if a bugfix though?