Re: [f2fs-dev] [PATCH v5 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

[Chao Yu]

On 2020/10/29 15:24, Chao Yu wrote:
> On 2020/10/29 12:15, Daeho Jeong wrote:

> > +	inode_lock(inode);
>
> It's minor,
>
> inode_lock_shared()?
>
> > +
> > +	if (!f2fs_compressed_file(inode)) {
> > +		inode_unlock(inode);
>
> inode_unlock_shared()?
>
> > +		return -ENODATA;
> > +	}
> > +
> > +	option.algorithm = F2FS_I(inode)->i_compress_algorithm;
> > +	option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
> > +
> > +	inode_unlock(inode);
>
> ditto.

Any comments?

Thanks,