Re: [Build fail] i386 & nvdimm is unhappy

From: Dan Williams
Date: Thu Oct 29 2020 - 21:28:08 EST


On Thu, Oct 29, 2020 at 4:49 PM Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>
> On Thu, Oct 29, 2020 at 4:29 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> > On 10/29/20 4:13 PM, Randy Dunlap wrote:
> > > On 10/29/20 4:09 PM, Philip Li wrote:
> > >> On Thu, Oct 29, 2020 at 03:52:42PM -0700, Dan Williams wrote:
> > >>> On Thu, Oct 29, 2020 at 3:44 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > >>>>
> > >>>> Dan,
> > >>>>
> > >>>> x86 32bit build fails with the config below with this:
> > >>>>
> > >>>> ERROR: modpost: "phys_to_target_node" [drivers/nvdimm/nd_e820.ko]
> > >>>> undefined!
> > >>>
> > >>> Acknowledged, I'm on it.
> > >>>
> > >>> Wonder how 0-day missed this or I missed the 0-day report?
> > >> Sorry about this Dan. Can you share some info like which kconfig and bad commit?
> > >> We will investigate this to provide update in earliest time.
> > >>
> > >> Thanks
> > >>
> > >>>
> > >
> > > I posted earlier today about the same failure on x86_64 & linux-next:
> > >
> > > https://lore.kernel.org/linux-next/0faac4da-a7bc-3fc7-e278-ad4f72499224@xxxxxxxxxxxxx/T/#u
> > >
> > >
> > > Thomas and I both included kernel config files.
> > >
> >
> > Here is a patch that Dan was cc-ed on.
> >
> > https://lore.kernel.org/linux-mm/aaae71a7-4846-f5cc-5acf-cf05fdb1f2dc@xxxxxxxxxx/
>
> Thanks for that archaeology Randy. That was when I was out on leave
> and I apologize for missing it. I'll get that merged up.

Andrew already rolled that in for -rc1, and looking at it I don't
think it is the right fix.