Re: [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component

From: Dave Stevenson
Date: Wed Oct 28 2020 - 20:02:12 EST


Hi Maxime

On Wed, 8 Jul 2020 at 15:46, Maxime Ripard <maxime@xxxxxxxxxx> wrote:
>
> Since the components for a given device in ASoC are identified by their
> name, it makes sense to add one even though it's not strictly necessary.
>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>

Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 15a11cd4de25..a057db0d9baa 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -983,6 +983,7 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
> };
>
> static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = {
> + .name = "vc4-hdmi-codec-dai-component",
> .controls = vc4_hdmi_audio_controls,
> .num_controls = ARRAY_SIZE(vc4_hdmi_audio_controls),
> .dapm_widgets = vc4_hdmi_audio_widgets,
> --
> 2.26.2
>