Re: [PATCH 2/2] vsock: fix the error return when an invalid ioctl command is used
From: Stefano Garzarella
Date: Tue Oct 27 2020 - 05:18:15 EST
On Tue, Oct 27, 2020 at 09:09:42AM +0000, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Currently when an invalid ioctl command is used the error return
is -EINVAL. Fix this by returning the correct error -ENOIOCTLCMD.
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
net/vmw_vsock/af_vsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 865331b809e4..597c86413089 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -2072,7 +2072,7 @@ static long vsock_dev_do_ioctl(struct file *filp,
break;
default:
- retval = -EINVAL;
+ retval = -ENOIOCTLCMD;
}
return retval;
--
2.27.0