Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Tue Oct 27 2020 - 02:28:13 EST


On Mon, Oct 26, 2020 at 03:04:45AM +0000, Sherry Sun wrote:
> Hi Greg & Christoph,
>
> > Subject: Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used
> > ring
> >
> > On Thu, Oct 22, 2020 at 01:06:36PM +0800, Sherry Sun wrote:
> > > We don't need to allocate and reassign the used ring here and remove
> > > the used_address_updated flag.Since RC has allocated the entire vring,
> > > including the used ring. Simply add the corresponding offset can get
> > > the used ring address.
> >
> > Someone needs to verify this vs the existing intel implementations.
>
> Hi Greg, @gregkh@xxxxxxxxxxxxxxxxxxx, sorry I don't have the Intel MIC devices so cannot test it, do you know anyone who can help test this patch changes on the Intel MIC platform? Thanks.

Why not ask the authors/maintainers of that code?

greg k-h