Re: [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint

From: Kazlauskas, Nicholas
Date: Mon Oct 26 2020 - 16:22:27 EST


Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>

Looks fine to me. Feel free to apply.

Regards,
Nicholas Kazlauskas

On 2020-10-26 3:34 p.m., Alex Deucher wrote:
Yes, looks good to me as well. Series is:
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
I'll give the display guys a few more days to look this over, but if
there are no objections, I'll apply them.

Thanks!

Alex

On Fri, Oct 23, 2020 at 7:16 PM Luben Tuikov <luben.tuikov@xxxxxxx> wrote:

On 2020-10-23 03:46, Takashi Iwai wrote:
Hi,

the amdgpu driver's ASSERT_CRITICAL() macro calls the
kgdb_breakpoing() even if no debug option is set, and this leads to a
kernel panic on distro kernels. The first two patches are the
oneliner fixes for those, while the last one is the cleanup of those
debug macros.

This looks like good work and solid. Hopefully it gets picked up.

Regards,
Luben



Takashi

===

Takashi Iwai (3):
drm/amd/display: Fix kernel panic by dal_gpio_open() error
drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally
drm/amd/display: Clean up debug macros

drivers/gpu/drm/amd/display/Kconfig | 1 +
drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c | 4 +--
drivers/gpu/drm/amd/display/dc/os_types.h | 33 +++++++++----------------
3 files changed, 15 insertions(+), 23 deletions(-)


_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx