Re: [patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage

From: Sebastian Andrzej Siewior
Date: Mon Oct 26 2020 - 08:47:59 EST


On 2020-10-25 17:56:47 [+0100], Johan Hovold wrote:
> There's a ton of issues with this driver, but this is arguably making
> things worse. A line discipline may call write() from just about any
> context so we cannot rely on tty being non-NULL here (e.g. PPP).

I wasn't aware of that. I've been looking at the callers each time a
`tty' was passed it looked like a preemptible context (due to mutex /
GFP_KERNEL) and so on.

>
> Johan

Sebastian