Re: [PATCH v2] nvme-rdma: handle nvme completion data length

From: Christoph Hellwig
Date: Sat Oct 24 2020 - 03:36:37 EST


On Fri, Oct 23, 2020 at 11:01:40AM -0700, Sagi Grimberg wrote:
>> + /* received data length checking */
>> + if (unlikely(wc->byte_len < len)) {
>> + /* zero bytes message could be ignored */
>> + if (!wc->byte_len) {
>> + nvme_rdma_post_recv(queue, qe);
>> + return;
>> + }
>
> Nothing in the spec defines zero-length messages, hence we cannot
> support something that is not standard. If your array needs this,
> please submit a TPAR to the NVMe TWG.

We'll still need sanity checking instead of the recount underflow,
I think tearing down the connection here and kicking off error recovery
is probably the best idea.