Re: [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint

From: Luben Tuikov
Date: Fri Oct 23 2020 - 19:18:13 EST


On 2020-10-23 03:46, Takashi Iwai wrote:
> Hi,
>
> the amdgpu driver's ASSERT_CRITICAL() macro calls the
> kgdb_breakpoing() even if no debug option is set, and this leads to a
> kernel panic on distro kernels. The first two patches are the
> oneliner fixes for those, while the last one is the cleanup of those
> debug macros.

This looks like good work and solid. Hopefully it gets picked up.

Regards,
Luben

>
>
> Takashi
>
> ===
>
> Takashi Iwai (3):
> drm/amd/display: Fix kernel panic by dal_gpio_open() error
> drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally
> drm/amd/display: Clean up debug macros
>
> drivers/gpu/drm/amd/display/Kconfig | 1 +
> drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c | 4 +--
> drivers/gpu/drm/amd/display/dc/os_types.h | 33 +++++++++----------------
> 3 files changed, 15 insertions(+), 23 deletions(-)
>