Re: [PATCH v2 1/2] kunit: Support for Parameterized Testing

From: Marco Elver
Date: Fri Oct 23 2020 - 14:56:36 EST


On Fri, 23 Oct 2020 at 20:48, Marco Elver <elver@xxxxxxxxxx> wrote:
[...]
> > + */
> > +static inline void *kunit_param_generator_helper(struct kunit *test,
>
> I don't think this needs to be inline, but see my other suggestion
> below, which might make this function obsolete.

Ah sorry, it's in a header so we might get complaints if it's not
inline. But in any case, if you use the KUNIT_ARRAY_PARAM() macro I
proposed, this function will become obsolete.

Thanks,
-- Marco