Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

From: Finn Thain
Date: Thu Oct 22 2020 - 23:21:07 EST


On Thu, 22 Oct 2020, Geert Uytterhoeven wrote:

>
> Thanks for your patch...
>

You're welcome.

> I can't say I'm a fan of this...
>

Sorry.

>
> The real issue is this "extern struct platform_device scc_a_pdev,
> scc_b_pdev", circumventing the driver framework.
>
> Can we get rid of that?
>

Is there a better alternative?

pmz_probe() is called by console_initcall(pmz_console_init) when
CONFIG_SERIAL_PMACZILOG_CONSOLE=y because this has to happen earlier than
the normal platform bus probing which takes place later as a typical
module_initcall.