Re: [PATCH v1 1/5] seq_file: Introduce DEFINE_STORE_ATTRIBUTE() helper macro

[Andy Shevchenko]

On Thu, Oct 22, 2020 at 04:39:53PM +0800, Luo Jiaxing wrote:
> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> for read-only file, but we found many of drivers want a helper marco for
> read-write file too.

I would expect that DEFINE_STORE maps to WO attribute...
For RW SHOW_STORE would be more appropriate.

Otherwise I think it makes sense.

-- 
With Best Regards,
Andy Shevchenko