Re: [PATCH v2] usb: dwc3: Trigger a GCTL soft reset when switching modes in DRD

From: Felipe Balbi
Date: Thu Oct 22 2020 - 03:55:24 EST



Hi,

John Stultz <john.stultz@xxxxxxxxxx> writes:
> From: Yu Chen <chenyu56@xxxxxxxxxx>
>
> With the current dwc3 code on the HiKey960 we often see the
> COREIDLE flag get stuck off in __dwc3_gadget_start(), which
> seems to prevent the reset irq and causes the USB gadget to
> fail to initialize.
>
> We had seen occasional initialization failures with older
> kernels but with recent 5.x era kernels it seemed to be becoming
> much more common, so I dug back through some older trees and
> realized I dropped this quirk from Yu Chen during upstreaming
> as I couldn't provide a proper rational for it and it didn't
> seem to be necessary. I now realize I was wrong.

This keeps coming back every few years. It has never been necessary so
far. Why is it necessary now? The only thing we need to do is verify
which registers are shadowed between host and peripheral roles and cache
only those registers.

A full soft reset will take a while and is likely to create other
issues.

--
balbi

Attachment: signature.asc
Description: PGP signature