Re: [PATCH net] net: hdlc_raw_eth: Clear the IFF_TX_SKB_SHARING flag after calling ether_setup

From: Jakub Kicinski
Date: Wed Oct 21 2020 - 21:02:18 EST


On Mon, 19 Oct 2020 23:34:20 -0700 Xie He wrote:
> This driver calls ether_setup to set up the network device.
> The ether_setup function would add the IFF_TX_SKB_SHARING flag to the
> device. This flag indicates that it is safe to transmit shared skbs to
> the device.
>
> However, this is not true. This driver may pad the frame (in eth_tx)
> before transmission, so the skb may be modified.
>
> Cc: Neil Horman <nhorman@xxxxxxxxxxxxx>
> Cc: Krzysztof Halasa <khc@xxxxxxxxx>
> Signed-off-by: Xie He <xie.he.0141@xxxxxxxxx>

Applied, thank you.

In the future please try to provide a Fixes: tag.