Re: [PATCH 2/2] blk-snap - snapshots and change-tracking for block devices

From: Randy Dunlap
Date: Wed Oct 21 2020 - 11:12:08 EST


On 10/21/20 2:04 AM, Sergei Shtepa wrote:
> diff --git a/drivers/block/blk-snap/Kconfig b/drivers/block/blk-snap/Kconfig
> new file mode 100644
> index 000000000000..7a2db99a80dd
> --- /dev/null
> +++ b/drivers/block/blk-snap/Kconfig
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# blk-snap block io layer filter module configuration
> +#
> +#
> +#select BLK_FILTER
> +
> +config BLK_SNAP
> + tristate "Block device snapshot filter"
> + depends on BLK_FILTER
> + help
> +

No blank line here.

> + Allow to create snapshots and track block changes for a block

for block

> + devices. Designed for creating backups for any block devices
> + (without device mapper). Snapshots are temporary and are released
> + then backup is completed. Change block tracking allows you to

when

> + create incremental or differential backups.
> +
> +config BLK_SNAP_SNAPSTORE_MULTIDEV
> + bool "Multi device snapstore configuration support"
> + depends on BLK_SNAP
> + help
> +
No blank line here.

> + Allow to create snapstore on multiple block devices.


thanks.
--
~Randy