Re: [PATCH 1/2] Block layer filter - second version

From: Randy Dunlap
Date: Wed Oct 21 2020 - 11:09:36 EST


On 10/21/20 2:04 AM, Sergei Shtepa wrote:
> diff --git a/block/Kconfig b/block/Kconfig
> index bbad5e8bbffe..a308801b4376 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -204,6 +204,17 @@ config BLK_INLINE_ENCRYPTION_FALLBACK
> by falling back to the kernel crypto API when inline
> encryption hardware is not present.
>
> +config BLK_FILTER
> + bool "Enable support for block layer filters"
> + default y

Drop the default y. We don't add modules to a default build without
some tough justification.

> + depends on MODULES
> + help
> + Enabling this lets third-party kernel modules intercept

lets loadable kernel modules intercept

> + bio requests for any block device. This allows them to implement
> + changed block tracking and snapshots without any reconfiguration of
> + the existing setup. For example, this option allows snapshotting of
> + a block device without adding it to LVM.


--
~Randy