Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

From: Matthieu Baerts
Date: Wed Oct 21 2020 - 06:54:19 EST


Hi Geert,

On 21/10/2020 11:52, Geert Uytterhoeven wrote:
Hi Matthieu,

On Wed, Oct 21, 2020 at 11:47 AM Matthieu Baerts
<matthieu.baerts@xxxxxxxxxxxx> wrote:
On 21/10/2020 11:43, Geert Uytterhoeven wrote:
On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
On 20/10/2020 09:38, Geert Uytterhoeven wrote:
MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may
not want to enable. Fix this by making MPTCP_IPV6 depend on IPV6, like
is done for all other IPv6 features.

Here again, the intension was to select IPv6 from MPTCP but I understand
the issue: if we enable MPTCP, we will select IPV6 as well by default.
Maybe not what we want on some embedded devices with very limited memory
where IPV6 is already off. We should instead enable MPTCP_IPV6 only if
IPV6=y. LGTM then!

Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>

Applied, thanks!

My apologies, this fails for the CONFIG_IPV6=m and CONFIG_MPTCP=y
case:

Good point, MPTCP cannot be compiled as a module (like TCP). It should
then depends on IPV6=y. I thought it would be the case.

Do you want me to send a patch or do you already have one?

I don't have a patch yet, so feel free to send one.

Just did:

https://lore.kernel.org/netdev/20201021105154.628257-1-matthieu.baerts@xxxxxxxxxxxx/

Groetjes,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net