Re: [RFC] treewide: cleanup unreachable breaks

From: Nick Desaulniers
Date: Tue Oct 20 2020 - 14:52:04 EST


On Tue, Oct 20, 2020 at 11:42 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Mon, 2020-10-19 at 12:42 -0700, Nick Desaulniers wrote:
> > We probably should add all 3 to W=2 builds (wrapped in cc-option).
> > I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to
> > follow up on.
>
> I suggest using W=1 as people that are doing cleanups
> generally use that and not W=123 or any other style.
>
> Every other use of W= is still quite noisy and these
> code warnings are relatively trivially to fix up.

The 0day bot folks have enabled W=1 recently; hence the uptick in
reports of -Wimplicit-function-declaration.

If it gets added to W=1, it's effectively "on by default" for new code
tested by 0day bot.
--
Thanks,
~Nick Desaulniers