Re: [PATCH v39 08/24] x86/sgx: Initialize metadata for Enclave Page Cache (EPC) sections

From: Dave Hansen
Date: Mon Oct 19 2020 - 09:40:39 EST


On 10/19/20 1:45 AM, Jarkko Sakkinen wrote:
> On Sat, Oct 03, 2020 at 07:50:43AM +0300, Jarkko Sakkinen wrote:
>> +config INTEL_SGX
> Since the directory for this was renamed some iterations ago from
> arch/x86/kernel/cpu/sgx to intel_sgx given the feedback from Boris,
> I'm wondering should this also be renamed as X86_SGX?

I say yes for two reasons:

We're recently adding a prohibition against vendors adding
VENDOR_FEATURE, preferring "FEATURE" instead. But, I seriously doubt
anyone else is going to to to the effort that Intel did here.

Also "SGX" is short enough that I can imagine someone else plausibly
wanting to do CONFIG_SGX for something else.

So, I'm OK with keeping "INTEL_SGX", but I'd also be fine with "X86_SGX".