Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

From: Jakub Kicinski
Date: Fri Oct 16 2020 - 17:32:08 EST


On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote:
> > These are tested to be the latest as part of the tools/lib/bpf build.
>
> But you didn't mention why you're making these changes, and you're
> removing a lot of comments without explaining why/where there might be
> a replacement or why the comments are useless. I now see that you're
> adding actual kdoc which is good, except for the part where
> you don't put kdoc on all the structures.

Note that he's just syncing the uAPI headers to tools/

The source of the change is here:

78a3ea555713 ("net: remove comments on struct rtnl_link_stats")
0db0c34cfbc9 ("net: tighten the definition of interface statistics")