Re: [PATCH 5/5] task_work: use TIF_NOTIFY_SIGNAL if available

From: Jens Axboe
Date: Fri Oct 16 2020 - 10:53:59 EST


On 10/16/20 8:51 AM, Oleg Nesterov wrote:
> On 10/16, Thomas Gleixner wrote:
>>
>> With moving the handling into get_signal() you don't need more changes
>> to arch/* than adding the TIF bit, right?
>
> we still need to do something like
>
> - if (thread_flags & _TIF_SIGPENDING)
> + if (thread_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
> do_signal(...);
>
> and add _TIF_NOTIFY_SIGNAL to the WORK-PENDING mask in arch/* code.

Yes, but it becomes really minimal at that point, and just that. There's
no touching any of the arch do_signal() code.

Just finished the update of the branch to this model, and it does simplify
things quite a bit! Most arch patches are now exactly just what you write
above, no more.

--
Jens Axboe