RE: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET

[Michael.Wu]

On 10/14/20 4:53 PM, andriy.shevchenko@xxxxxxxxxxxxxxx wrote:
> 
> Wondering if you compile this at all...


I'm very sorry that I did not compile it because I only have ARM SoC with my
linux 4.9.170, but I've verified the logic of this patch in my linux.

I'll correct these two syntax errors in next version. The reported
warnings occurs from drivers/i2c/busses/i2c-designware-slave.c:13 seems
not made by this modification. Please correct me if I'm wrong....

> >    include/asm-generic/io.h:1017:55: warning: performing pointer
> arithmetic on a null pointer has undefined behavior
> [-Wnull-pointer-arithmetic]
> >            return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE +
> port;
> >
> ~~~~~~~~~~ ^
> > >> drivers/i2c/busses/i2c-designware-slave.c:181:42: error: expected ';' after
> expression
> >                            dev->status =
> STATUS_WRITE_IN_PROGRESS
> >
> ^
> >
>    ;
> > >> drivers/i2c/busses/i2c-designware-slave.c:195:22: error: use of
> undeclared identifier 'STATUS_IDEL'
> >                    if (dev->status != STATUS_IDEL) {
> >                                       ^
> >    7 warnings and 2 errors generated.
> 
> 
>