Re: [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS

From: Lukas Bulwahn
Date: Wed Oct 14 2020 - 05:14:37 EST




On Tue, 13 Oct 2020, Joe Perches wrote:

> On Wed, 2020-10-14 at 08:36 +0200, Lukas Bulwahn wrote:
> >
> > On Tue, 13 Oct 2020, Joe Perches wrote:
> >
> > > On Wed, 2020-10-14 at 08:21 +0200, Lukas Bulwahn wrote:
> > > > What does checkpatch.pl warn about and what does clang-format still warn
> > > > about, which is generally accepted okay as style in the kernel?
> > >
> > > clang-format doesn't warn at all, it just reformats.
> > >
> > You can run clang-format with --dry-run and then it would just state the
> > proposed changes, right?
>
> clang-format through at least version 10 does not have
> a --dry-run option.
>
>

Just a quick check:

version 9 does not have the --dry-run option:

https://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormat.html

version 10 does:

https://releases.llvm.org/10.0.0/tools/clang/docs/ClangFormat.html

and version 12 (under development) does keep it:

https://clang.llvm.org/docs/ClangFormat.html

I have not played around with that, though.

Lukas