Re: [PATCH v10 6/8] arm: dts: rockchip: Add NFC node for RV1108 SoC

[Kever Yang]

On 2020/9/30 上午10:09, Yifeng Zhao wrote:
> Add NAND FLASH Controller(NFC) node for RV1108 SoC.
>
> Signed-off-by: Yifeng Zhao <yifeng.zhao@xxxxxxxxxxxxxx>
> ---
>
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>   arch/arm/boot/dts/rv1108.dtsi | 11 +++++++++++
>   1 file changed, 11 insertions(+)

Looks good to me,

Reviewed-by: Kever Yang<kever.yang@xxxxxxxxxxxxxx>

Thanks,
- Kever

> diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
> index a1a08cb9364e..1696ea19488b 100644
> --- a/arch/arm/boot/dts/rv1108.dtsi
> +++ b/arch/arm/boot/dts/rv1108.dtsi
> @@ -452,6 +452,17 @@
>   		#reset-cells = <1>;
>   	};
>   
> +	nfc: nand-controller@30100000 {
> +		compatible = "rockchip,rv1108-nfc";
> +		reg = <0x30100000  0x1000>;
> +		interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru HCLK_NANDC>, <&cru SCLK_NANDC>;
> +		clock-names = "ahb", "nfc";
> +		assigned-clocks = <&cru SCLK_NANDC>;
> +		assigned-clock-rates = <150000000>;
> +		status = "disabled";
> +	};
> +
>   	emmc: mmc@30110000 {
>   		compatible = "rockchip,rv1108-dw-mshc", "rockchip,rk3288-dw-mshc";
>   		reg = <0x30110000 0x4000>;