Re: [PATCH] xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n

From: Eric Sandeen
Date: Mon Oct 12 2020 - 17:32:08 EST


On 10/12/20 4:11 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Pavel Machek complained that the question about supporting deprecated
> XFS v4 comes up even when XFS is disabled. This clearly makes no sense,
> so fix Kconfig.
>
> Reported-by: Pavel Machek <pavel@xxxxxx>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
> fs/xfs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index 5422227e9e93..9fac5ea8d0e4 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -24,6 +24,7 @@ config XFS_FS
>
> config XFS_SUPPORT_V4
> bool "Support deprecated V4 (crc=0) format"
> + depends on XFS_FS
> default y
> help
> The V4 filesystem format lacks certain features that are supported
>