Re: [PATCH 2/2] dt-bindings: extcon: add binding for TUSB320

[Chanwoo Choi]

On 10/9/20 7:39 AM, Michael Auchter wrote:
> Add a device tree binding for the TI TUSB320.
> 
> Signed-off-by: Michael Auchter <michael.auchter@xxxxxx>
> ---
>  .../bindings/extcon/extcon-usbc-tusb320.yaml  | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml b/Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml
> new file mode 100644
> index 000000000000..57f1bcbf1295
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: https://protect2.fireeye.com/v1/url?k=24582026-79962192-2459ab69-000babdfecba-1931f18c81ab64e5&q=1&e=8094c8b6-bc5c-4c39-b23a-4f81a9cccae3&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fextcon%2Fextcon-usbc-tusb320.yaml%23
> +$schema: https://protect2.fireeye.com/v1/url?k=8c20f14c-d1eef0f8-8c217a03-000babdfecba-6159bd3aeb5a40ca&q=1&e=8094c8b6-bc5c-4c39-b23a-4f81a9cccae3&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
> +
> +title: TI TUSB320 USB Type-C CC Logic controller
> +
> +maintainers:
> +  - Michael Auchter <michael.auchter@xxxxxx>
> +
> +properties:
> +  compatible:
> +    const: ti,tusb320
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c0 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        extcon@61 {

Better to use 'tusb320' instead of 'extcon' word
because extcon doesn't represent the hardware.

> +            compatible = "ti,tusb320";
> +            reg = <0x61>;
> +            interrupt-parent = <&gpio>;
> +            interrupts = <27 1>;
> +        };
> +    };
> +...
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics