Re: [PATCH] ARM: dts: sun8i: h2+: Enable optional SPI flash on Orange Pi Zero board

[Maxime Ripard]

Hi,

On Tue, Sep 29, 2020 at 10:30:25AM +0200, Michal Suchanek wrote:
> The flash is present on all new boards and users went out of their way
> to add it on the old ones.
> 
> Enabling it makes a more reasonable default.
> 
> Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> ---
>  arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> index f19ed981da9d..061d295bbba7 100644
> --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> @@ -163,8 +163,8 @@ &ohci1 {
>  };
>  
>  &spi0 {
> -	/* Disable SPI NOR by default: it optional on Orange Pi Zero boards */
> -	status = "disabled";
> +	/* Enable optional SPI NOR by default */
> +	status = "okay";
>  
>  	flash@0 {
>  		#address-cells = <1>;

Unfortunately, it's optional, so there's really no reason to enable it
all the time. If it's troublesome to users, then the distros or vendors
should make the changes necessary to the hardware, bootloader or their
documentation to make it easier for those users.

Maxime

Attachment: signature.asc
Description: PGP signature