Re: [PATCH 2/3] Input: Add Novatek NT36xxx touchscreen driver

From: kernel test robot
Date: Sat Sep 26 2020 - 16:28:36 EST


Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on input/next]
[also build test WARNING on robh/for-next v5.9-rc6 next-20200925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/kholk11-gmail-com/Add-Novatek-NT36xxx-touchscreen-driver/20200926-204916
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-randconfig-s032-20200927 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
# https://github.com/0day-ci/linux/commit/6d9ee3df7e7fa769137ec343ea91ebf87bcf24cb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review kholk11-gmail-com/Add-Novatek-NT36xxx-touchscreen-driver/20200926-204916
git checkout 6d9ee3df7e7fa769137ec343ea91ebf87bcf24cb
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)

>> drivers/input/touchscreen/nt36xxx.c:17:30: sparse: sparse: symbol 'nt36xxx_memory_maps' was not declared. Should it be static?
>> drivers/input/touchscreen/nt36xxx.c:25:33: sparse: sparse: symbol 'trim_id_table' was not declared. Should it be static?
>> drivers/input/touchscreen/nt36xxx.c:396:58: sparse: sparse: invalid access past the end of 'buf' (3 3)
drivers/input/touchscreen/nt36xxx.c:395:58: sparse: sparse: invalid access past the end of 'buf' (3 3)

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip