Re: [PATCH] net: stmmac: dwmac-meson8b: add calibration registers

From: David Miller
Date: Fri Sep 25 2020 - 19:26:15 EST


From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
Date: Fri, 25 Sep 2020 23:56:29 +0200

> The Amlogic dwmac Ethernet IP glue has two registers:
> - PRG_ETH0 with various configuration bits
> - PRG_ETH1 with various calibration and information related bits
>
> Add the register definitions with comments from different drivers in
> Amlogic's vendor u-boot and Linux.
>
> The most important part is PRG_ETH1_AUTO_CALI_IDX_VAL which is needed on
> G12A (and later: G12B, SM1) with RGMII PHYs. Ethernet is only working up
> to 100Mbit/s speeds if u-boot does not initialize these bits correctly.
> On 1Gbit/s links no traffic is flowing (similar to when the RGMII delays
> are set incorrectly). The logic to write this register will be added
> later.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

Please add these definitions alongside actual uses of them.

Thank you.