Re: [Intel-gfx] [PATCH 08/11] drm/i915: use vmap in i915_gem_object_map

From: Christoph Hellwig
Date: Fri Sep 25 2020 - 12:02:52 EST


On Fri, Sep 25, 2020 at 03:08:59PM +0100, Matthew Auld wrote:
> > + i = 0;
> > + for_each_sgt_page(page, iter, obj->mm.pages)
> > + pages[i++] = page;
> > + vaddr = vmap(pages, n_pages, 0, pgprot);
> > + if (pages != stack)
> > + kvfree(pages);
> > + return vaddr;
> > +}

> > - return area->addr;
> > + for_each_sgt_daddr(addr, iter, obj->mm.pages)
> > + pfns[i++] = (iomap + addr) >> PAGE_SHIFT;
>
> Missing the i = 0 fix from Dan?

Yeah, looks like I only managed to apply the one in the page based
version above.