Re: [PATCH -next] MIPS: OCTEON: fix error - use 'ret' after remove it

From: Sergei Shtylyov
Date: Thu Sep 24 2020 - 04:16:54 EST


Hello!

On 24.09.2020 9:41, Qinglang Miao wrote:

Variable ret was removed in commit 0ee69c589ec("MIPS: OCTEON:

I'm only seeing the variable 'res' below...

use devm_platform_ioremap_resource") but still being used in
devm_release_mem_region which is unneeded. So remove this
line to fix error.

Fixes: 0ee69c589ec("MIPS: OCTEON: use devm_platform_ioremap_resource")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
---
arch/mips/cavium-octeon/octeon-usb.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/mips/cavium-octeon/octeon-usb.c b/arch/mips/cavium-octeon/octeon-usb.c
index 97f6dc31e1b4..987a94cbf3d0 100644
--- a/arch/mips/cavium-octeon/octeon-usb.c
+++ b/arch/mips/cavium-octeon/octeon-usb.c
@@ -534,8 +534,6 @@ static int __init dwc3_octeon_device_init(void)
dev_info(&pdev->dev, "clocks initialized.\n");
mutex_unlock(&dwc3_octeon_clocks_mutex);
devm_iounmap(&pdev->dev, base);
- devm_release_mem_region(&pdev->dev, res->start,
- resource_size(res));
}
} while (node != NULL);

MBR, Sergei