Re: [Intel-gfx] [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map

From: Christoph Hellwig
Date: Wed Sep 23 2020 - 09:41:25 EST


On Wed, Sep 23, 2020 at 10:52:33AM +0100, Tvrtko Ursulin wrote:
>
> On 18/09/2020 17:37, Christoph Hellwig wrote:
>> i915_gem_object_map implements fairly low-level vmap functionality in
>> a driver. Split it into two helpers, one for remapping kernel memory
>> which can use vmap, and one for I/O memory that uses vmap_pfn.
>>
>> The only practical difference is that alloc_vm_area prefeaults the
>> vmalloc area PTEs, which doesn't seem to be required here for the
>> kernel memory case (and could be added to vmap using a flag if actually
>> required).
>
> Patch looks good to me.
>
> Series did not get a CI run from our side because of a different base so I
> don't know if you would like to have a run there? If so you would need to
> rebase against git://anongit.freedesktop.org/drm-tip drm-tip and you could
> even send a series to intel-gfx-trybot@xxxxxxxxxxxxxxxxxxxxx, suppressing
> cc, to check it out without sending a copy to the real mailing list.

It doesn't seem like I can post to any freedesktop list, as I always
get rejection messages. But I'll happily prepare a branch if one
of you an feed it into your CI.