Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters

From: Marek Behún
Date: Wed Sep 23 2020 - 09:10:46 EST


On Tue, 22 Sep 2020 14:06:38 -0500
Dan Murphy <dmurphy@xxxxxx> wrote:

> Fix warnings for undefined parameters when building with W=1.
>
> Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver")
> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> ---
> drivers/leds/leds-lm36274.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c
> index 10a63b7f2ecc..bf6487e9a1f4 100644
> --- a/drivers/leds/leds-lm36274.c
> +++ b/drivers/leds/leds-lm36274.c
> @@ -26,8 +26,8 @@
> * @lmu_data: Register and setting values for common code
> * @regmap: Devices register map
> * @dev: Pointer to the devices device struct
> - * @led_sources - The LED strings supported in this array
> - * @num_leds - Number of LED strings are supported in this array
> + * @led_sources: The LED strings supported in this array
> + * @num_leds: Number of LED strings are supported in this array
> */
> struct lm36274 {
> struct platform_device *pdev;
> @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = {
> .probe = lm36274_probe,
> .driver = {
> .name = "lm36274-leds",
> + .of_match_table = of_lm36274_leds_match,
> },
> };
> module_platform_driver(lm36274_driver)

Reviewed-by: Marek Behún <kabel@xxxxxxxxxx>