Re: [PATCH] soc: actions: include header to fix missing prototype

From: Manivannan Sadhasivam
Date: Tue Sep 22 2020 - 02:30:12 EST


On Sun, Sep 20, 2020 at 10:26:52PM +0200, Krzysztof Kozlowski wrote:
> Include the header with prototype of owl_sps_set_pg to fix:
>
> drivers/soc/actions/owl-sps-helper.c:16:5: warning: no previous prototype for 'owl_sps_set_pg' [-Wmissing-prototypes]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Thanks,
Mani

> ---
> drivers/soc/actions/owl-sps-helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/actions/owl-sps-helper.c b/drivers/soc/actions/owl-sps-helper.c
> index 291a206d6f04..e3f36603dd53 100644
> --- a/drivers/soc/actions/owl-sps-helper.c
> +++ b/drivers/soc/actions/owl-sps-helper.c
> @@ -10,6 +10,7 @@
>
> #include <linux/delay.h>
> #include <linux/io.h>
> +#include <linux/soc/actions/owl-sps.h>
>
> #define OWL_SPS_PG_CTL 0x0
>
> --
> 2.17.1
>