Re: [PATCH RFT/RFC 37/49] staging: media: zoran: add fallthrough keyword

From: Dan Carpenter
Date: Mon Sep 21 2020 - 07:00:26 EST


On Mon, Sep 21, 2020 at 10:20:12AM +0000, Corentin Labbe wrote:
> This patch adds fallthrough keyword where appropriate.
>
> Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>
> ---
> drivers/staging/media/zoran/zoran_device.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
> index 9558bafdde7d..7634d94f9359 100644
> --- a/drivers/staging/media/zoran/zoran_device.c
> +++ b/drivers/staging/media/zoran/zoran_device.c
> @@ -268,7 +268,9 @@ static void zr36057_adjust_vfe(struct zoran *zr, enum zoran_codec_mode mode)
> btwrite(reg, ZR36057_VFEHCR);
> break;
> case BUZ_MODE_MOTION_COMPRESS:
> + fallthrough;
> case BUZ_MODE_IDLE:
> + fallthrough;
> default:

Hopefully, we don't need fallthrough labels for empty switch statements
like this?

regards,
dan carpenter