Re: [PATCH v2 33/37] kasan, arm64: implement HW_TAGS runtime

From: Marco Elver
Date: Fri Sep 18 2020 - 06:47:02 EST


On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote:
[...]
> arch/arm64/include/asm/memory.h | 4 +-
> arch/arm64/kernel/setup.c | 1 -
> include/linux/kasan.h | 6 +--
> include/linux/mm.h | 2 +-
> include/linux/page-flags-layout.h | 2 +-
> mm/kasan/Makefile | 5 ++
> mm/kasan/common.c | 14 +++---
> mm/kasan/kasan.h | 17 +++++--
> mm/kasan/report_tags_hw.c | 47 +++++++++++++++++++
> mm/kasan/report_tags_sw.c | 2 +-
> mm/kasan/shadow.c | 2 +-
> mm/kasan/tags_hw.c | 78 +++++++++++++++++++++++++++++++
> mm/kasan/tags_sw.c | 2 +-
> 13 files changed, 162 insertions(+), 20 deletions(-)
> create mode 100644 mm/kasan/report_tags_hw.c
> create mode 100644 mm/kasan/tags_hw.c
[...]
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 77c4c9bad1b8..5985be8af2c6 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -358,7 +358,6 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p)
> smp_init_cpus();
> smp_build_mpidr_hash();
>
> - /* Init percpu seeds for random tags after cpus are set up. */

Why was the comment removed and not updated?

> kasan_init_tags();
>
> #ifdef CONFIG_ARM64_SW_TTBR0_PAN