Re: [PATCH v3 0/3] arm64: Convert to ARCH_STACKWALK

From: Miroslav Benes
Date: Wed Sep 16 2020 - 16:53:21 EST


On Mon, 14 Sep 2020, Mark Brown wrote:

> This series updates the arm64 stacktrace code to use the newer and much
> simpler arch_stack_walk() interface, the main benefit being a single
> entry point to the arch code with no need for the arch code to worry
> about skipping frames. Along the way I noticed that the reliable
> parameter to the arch_stack_walk() callback appears to be redundant
> so there's also a patch here removing that from the existing code to
> simplify the interface.
>
> This is preparatory work for implementing reliable stack trace for
> arm64.
>
> v3:
> - Rebase onto v5.9-rc3.
> - Fix handling of task == current.
> - Flip the sense of the walk_stackframe() callback.
> v2:
> - Rebase onto v5.9-rc1.
>
> Mark Brown (3):
> stacktrace: Remove reliable argument from arch_stack_walk() callback
> arm64: stacktrace: Make stack walk callback consistent with generic
> code
> arm64: stacktrace: Convert to ARCH_STACKWALK

The patches look good to me.

Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

M