Re: [PATCH 2/2] sched/hotplug: Ensure only per-cpu kthreads run during hotplug

From: peterz
Date: Wed Sep 16 2020 - 16:47:13 EST


On Wed, Sep 16, 2020 at 03:58:17PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-09-16 14:10:20 [+0200], peterz@xxxxxxxxxxxxx wrote:
>
> squeeze that in please:
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index a4fe22b8b8418..bed3cd28af578 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6866,7 +6866,7 @@ static int __balance_push_cpu_stop(void *arg)
> raw_spin_lock_irq(&p->pi_lock);
> rq_lock(rq, &rf);
>
> - update_rq_clock();
> + update_rq_clock(rq);
>
> if (task_rq(p) == rq && task_on_rq_queued(p)) {
> cpu = select_fallback_rq(rq->cpu, p);
>
>
> and count me in :)

Duh... /me goes in search of the brown paper bag -- again!