Re: [PATCH] scsi: esas2r: prevent a potential NULL dereference in esas2r_probe()

From: Jing Xiangfeng
Date: Wed Sep 16 2020 - 16:36:00 EST




On 2020/9/16 5:44, Martin K. Petersen wrote:

Jing,

esas2r_probe() calls scsi_host_put() in an error path. However,
esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead.

Wouldn't it be better to move the scsi_host_put() call after the error
message?

There is already a message before the scsi_host_put() call. It is used to record calling function.