Re: [PATCH v3 0/5] HWpoison: further fixes and cleanups

From: osalvador
Date: Wed Sep 16 2020 - 14:14:14 EST


On 2020-09-16 19:58, Aristeu Rozanski wrote:
On Wed, Sep 16, 2020 at 06:34:52PM +0200, osalvador@xxxxxxx wrote:
Fat fingers, sorry:

Ok, this is something different.
The race you saw previously is kinda normal as there is a race window
between spotting a freepage and taking it off the buddy freelists.
The retry patch should help there.

The issue you are seeing right here is due to the call to
page_handle_poison in __soft_offline_page being wrong, as we pass
hugepage_or_freepage = true inconditionally, which is wrong.
I think it was caused during rebasing.

Should be:

Tests passed with this patch on top of others.
Thanks!

Thanks for giving it a shot!
I will be sending patches tomorrow morning.

Thanks