Re: [Cocci] [RFC PATCH] scripts: coccicheck: Improve error feedback when coccicheck fails
From: Julia Lawall
Date: Mon Sep 14 2020 - 02:21:39 EST
On Mon, 14 Sep 2020, Markus Elfring wrote:
> …
> > +++ b/scripts/coccicheck
> > @@ -126,8 +126,14 @@ run_cmd_parmap() {
> > if [ $VERBOSE -ne 0 ] ; then
> > echo "Running ($NPROC in parallel): $@"
> > fi
> > - echo $@ >>$DEBUG_FILE
> > - $@ 2>>$DEBUG_FILE
> > + if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
> …
>
> How do you think about to use the following check variant?
>
> + if [ "${DEBUG_FILE}" != '/dev/null' -a "${DEBUG_FILE}" != '' ]; then
What difference does it make?
julia