Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()

From: David Miller
Date: Sat Sep 12 2020 - 21:23:32 EST


From: Luo Jiaxing <luojiaxing@xxxxxxxxxx>
Date: Sat, 12 Sep 2020 16:08:15 +0800

> We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it will
> cause a warning when build the kernel. And after checking the commit record
> of this function, we found that it was introduced by a previous patch.
>
> So, We delete this redundant assignment code.
>
> Fixes: 488a9b48e398 ("net/mlx4_en: Wake TX queues only when there's enough room")
>
> Signed-off-by: Luo Jiaxing <luojiaxing@xxxxxxxxxx>

Looks good, applied, thanks.